RFR: 8307100: Remove ReferentBasedDiscovery reference discovery policy

David Holmes dholmes at openjdk.org
Tue May 2 09:13:17 UTC 2023


On Fri, 28 Apr 2023 12:04:08 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Mostly consisting of mechanic refactoring after replacing `RefDiscoveryPolicy == ...` with `true` or `false`.
> 
> Test: tier1-6

The obsoletion of RefDiscoveryPolicy by always using refernce-based seems fine.

One query below.

Thanks.

src/hotspot/share/runtime/arguments.cpp line 526:

> 524:   { "G1ConcRSLogCacheSize",         JDK_Version::undefined(), JDK_Version::jdk(21), JDK_Version::undefined() },
> 525:   { "G1ConcRSHotCardLimit",         JDK_Version::undefined(), JDK_Version::jdk(21), JDK_Version::undefined() },
> 526:   { "RefDiscoveryPolicy",           JDK_Version::undefined(), JDK_Version::jdk(21), JDK_Version::undefined() },

Any specific reason to not target removal in JDK 22?

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13715#pullrequestreview-1408711467
PR Review Comment: https://git.openjdk.org/jdk/pull/13715#discussion_r1182292697


More information about the hotspot-dev mailing list