RFR: 8291550: RISC-V: jdk uses misaligned memory access when AvoidUnalignedAccess enabled [v5]
Vladimir Kempik
vkempik at openjdk.org
Thu May 4 16:46:39 UTC 2023
On Thu, 4 May 2023 15:30:07 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:
>> src/hotspot/cpu/riscv/interp_masm_riscv.cpp line 228:
>>
>>> 226: slli(tmp, tmp, 24);
>>> 227: add(index, index, tmp);
>>> 228: } else {
>>
>> Does it really make sense to do this here? Shouldn't there be an unaligned version of `lwu` in MacroAssembler?
>
> Sounds interesting.
Updated the PR, load_word_misaligned looks slightly ugly due to **Address -> (Address + offset)** conversion
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13645#discussion_r1185261979
More information about the hotspot-dev
mailing list