RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v9]
Cesar Soares Lucas
cslucas at openjdk.org
Wed May 3 20:28:32 UTC 2023
On Fri, 21 Apr 2023 19:23:37 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>>> Again got failures in the test on Aarch64 running with -XX:-UseTLAB:
>>>
>>> ```
>>> testCmpMergeWithNull(boolean,int,int):
>>> - Failed comparison: [found] 0 = 2 [given]
>>> testCmpMergeWithNull_Second(boolean,int,int)
>>> - Failed comparison: [found] 0 = 1 [given]
>>> testMergedAccessAfterCallNoWrite(boolean,int,int)
>>> - Failed comparison: [found] 2 = 3 [given]
>>> testMergedAccessAfterCallWithWrite(boolean,int,int)
>>> - Failed comparison: [found] 2 = 3 [given]
>>> testNestedObjectsArray(boolean,int,int)
>>> - Failed comparison: [found] 2 = 4 [given]
>>> ```
>>
>> @vnkozlov - The reason for these failures is due to an issue in the test framework ALLOC Regex: https://bugs.openjdk.org/browse/JDK-8306625 . Since only the tests added in this PR are failing due to that problem do you think I should create a separate PR to fix the Regex or just include the fix in this PR?
>
>> Since only the tests added in this PR are failing due to that problem do you think I should create a separate PR to fix the Regex or just include the fix in this PR?
>
> Create separate PR and fix it first. This PR still need review from @iwanowww and it may take time to address additional comments.
@vnkozlov - Please let me know if you have further questions.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/12897#issuecomment-1533687457
More information about the hotspot-dev
mailing list