RFR: 8291550: RISC-V: jdk uses misaligned memory access when AvoidUnalignedAccess enabled [v5]

Vladimir Kempik vkempik at openjdk.org
Thu May 4 15:33:21 UTC 2023


On Thu, 4 May 2023 14:53:00 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   simpify branching in branch opcodes
>
> src/hotspot/cpu/riscv/interp_masm_riscv.cpp line 228:
> 
>> 226:       slli(tmp, tmp, 24);
>> 227:       add(index, index, tmp);
>> 228:     } else {
> 
> Does it really make sense to do this here? Shouldn't there be an unaligned version of `lwu` in MacroAssembler?

Sounds interesting.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13645#discussion_r1185197010


More information about the hotspot-dev mailing list