RFR: 8307139: Fix signed integer overflow in compiler code, part 1 [v2]
Vladimir Kozlov
kvn at openjdk.org
Thu May 4 16:59:17 UTC 2023
On Thu, 4 May 2023 07:44:16 GMT, Dean Long <dlong at openjdk.org> wrote:
>> These changes attempt to fix signed overflow caught by running tier1 with -ftrapv. I expect more changes will be needed.
>> Most of the fixes are straight-forward and involve using unsigned or java_* functions that wrap. However, I did try to improve the usefulness of _debug_idx because as it was the high digits of the value were monotonic but unpredictable. Now the high digits use the compile_id, which seems like an improvement.
>
> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
>
> make room for all digits of _idx in debug_idx
src/hotspot/share/opto/idealGraphPrinter.cpp line 382:
> 380: #ifdef ASSERT
> 381: print_prop("debug_idx", node->_debug_idx);
> 382: #endif
Why you removed this?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13767#discussion_r1185276235
More information about the hotspot-dev
mailing list