RFR: 8307139: Fix signed integer overflow in compiler code, part 1 [v2]

Dean Long dlong at openjdk.org
Thu May 4 18:23:23 UTC 2023


On Thu, 4 May 2023 16:56:11 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   make room for all digits of _idx in debug_idx
>
> src/hotspot/share/opto/idealGraphPrinter.cpp line 382:
> 
>> 380: #ifdef ASSERT
>> 381:     print_prop("debug_idx", node->_debug_idx);
>> 382: #endif
> 
> Why you removed this?

print_prop() only works for int.  I could add an overload that works for uint64_t, but then I realized debug_idx is redundant for IGV, as we already have the compile_id and node _idx.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13767#discussion_r1185357845


More information about the hotspot-dev mailing list