RFR: 8307423: [s390x] Represent Registers as values [v2]
Amit Kumar
amitkumar at openjdk.org
Fri May 5 01:56:28 UTC 2023
On Thu, 4 May 2023 19:49:45 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> formatting & suggestions from @TheRealMDoerr
>
> src/hotspot/cpu/s390/register_s390.hpp line 186:
>
>> 184:
>> 185: // tester
>> 186: constexpr bool is_valid() const { return 0 <= _encoding && _encoding < number_of_registers; }
>
> Indentation is different than for the other register types. I suggest to adapt it, here.
Done; I did some other formatting changes, Please let me know if they looks good, I can happily revert them otherwise.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13805#discussion_r1185644215
More information about the hotspot-dev
mailing list