RFR: 8307423: [s390x] Represent Registers as values [v2]

[Martin Doerr]

On Fri, 5 May 2023 01:34:20 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> src/hotspot/cpu/s390/assembler_s390.hpp line 196:
>> 
>>> 194:     _index(index),
>>> 195:     _disp(disp) {}
>>> 196: 
>> 
>> I can live with the removal, but I guess it may be useful at some point of time. s390 supports specifying both, index and disp (unlike PPC64).
>
> This constructor was causing ambiguity with this one :
> 
>   Address(Register base, RegisterOrConstant roc, intptr_t disp = 0) :
>     _base(base),
>     _index(noreg),
>     _disp(disp) {
>     if (roc.is_constant()) _disp += roc.as_constant(); else _index = roc.as_register();
>   }
> 
> 
> that's why I removed it. But yeah I can try to find another workaround, any suggestion from your side ?

Ah, got it. I'm fine with the removal. The other constructor can be used as replacement.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13805#discussion_r1185890353