RFR: 8307423: [s390x] Represent Registers as values [v2]

[Martin Doerr]

On Fri, 5 May 2023 02:10:51 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   formatting & suggestions from @TheRealMDoerr
>
> src/hotspot/cpu/s390/vmreg_s390.inline.hpp line 32:
> 
>> 30:   if (this == noreg) {
>> 31:     return VMRegImpl::Bad();
>> 32:   }
> 
> Although @TheRealMDoerr  you've reviewed the changes. Do you think this getting rid from this check is okay? No other arch have this & this was an Typecasting error for us, after these changes.

Fine with me. PPC64 still has it, but if it's not used, I think it's ok to remove it. We have the `assert(is_valid(), "invalid register")` in `encoding()` to catch it.
If you prefer to keep it, you need to use `*this`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13805#discussion_r1185911376