RFR: JDK-8305506: Add support for fractional values of SafepointTimeoutDelay [v4]
Wojciech Kudla
duke at openjdk.org
Fri May 5 11:07:28 UTC 2023
On Tue, 2 May 2023 09:45:55 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Wojciech Kudla has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update full name
>
> test/hotspot/jtreg/runtime/CommandLine/DoubleFlagWithIntegerValue.java line 53:
>
>> 51:
>> 52: // Test double format for -XX:SafepointTimeoutDelay
>> 53: testDoubleFlagWithValue("-XX:SafepointTimeoutDelay", "0.050");
>
> This case doesn't belong in `DoubleFlagWithIntegerValue` as it is not an integer value. I believe this will be covered more broadly by test ` runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java`.
>
> In this test you should follow the existing patter and test e.g. 5 and 5.0
Sorry, @dholmes-ora this is absolutely correct. Double values are automatically tested by `TestOptionsWithRanges`. I updated the code in `DoubleFlagWithIntegerValue` to follow the spirit of the whole test.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13373#discussion_r1185962764
More information about the hotspot-dev
mailing list