RFR: 8307139: Fix signed integer overflow in compiler code, part 1 [v2]

[Tobias Hartmann]

On Thu, 4 May 2023 07:44:16 GMT, Dean Long <dlong at openjdk.org> wrote:

>> These changes attempt to fix signed overflow caught by running tier1 with -ftrapv.  I expect more changes will be needed.
>> Most of the fixes are straight-forward and involve using unsigned or java_* functions that wrap.  However, I did try to improve the usefulness of _debug_idx because as it was the high digits of the value were monotonic but unpredictable.  Now the high digits use the compile_id, which seems like an improvement.
>
> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
> 
>   make room for all digits of _idx in debug_idx

Looks reasonable to me. Another review would be good.

I'm actually wondering if anyone is using `BreakAtNode` or if we should simply deprecate/remove it.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13767#pullrequestreview-1418731647