RFR: 8307139: Fix signed integer overflow in compiler code, part 1 [v2]

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Wed May 10 13:47:22 UTC 2023


On Thu, 4 May 2023 18:19:59 GMT, Dean Long <dlong at openjdk.org> wrote:

>> src/hotspot/share/opto/idealGraphPrinter.cpp line 382:
>> 
>>> 380: #ifdef ASSERT
>>> 381:     print_prop("debug_idx", node->_debug_idx);
>>> 382: #endif
>> 
>> Why you removed this?
>
> print_prop() only works for int.  I could add an overload that works for uint64_t, but then I realized debug_idx is redundant for IGV, as we already have the compile_id and node _idx.

Removing `debug_idx` from IGV graph dumps makes sense to me as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13767#discussion_r1189934252


More information about the hotspot-dev mailing list