RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v21]

[Martin Doerr]

On Mon, 27 Mar 2023 16:54:31 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move ABIv2CallArranger out of linux subdirectory. ABIv1/2 does match the AIX/linux separation.
>
> src/hotspot/cpu/ppc/downcallLinker_ppc.cpp line 185:
> 
>> 183: 
>> 184:   allocated_frame_size = align_up(allocated_frame_size, StackAlignmentInBytes);
>> 185:   _frame_size_slots = allocated_frame_size >> LogBytesPerInt;
> 
> `VMRegImpl::stack_slot_size` could be used when converting from size in bytes to size in slots.

Yes, I think this would be better readable. But the following code should also be adapted, then:

  int framesize() const {
    return (_frame_size_slots >> (LogBytesPerWord - LogBytesPerInt));
  }

Maybe it makes sense to do some cleanup for all platforms.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12708#discussion_r1189741783