RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v22]

[Richard Reingruber]

On Tue, 18 Apr 2023 10:44:03 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Implementation of "Foreign Function & Memory API" for linux on Power (Little Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>> 
>> This PR does not include code for VaList support because it's supposed to get removed by [JDK-8299736](https://bugs.openjdk.org/browse/JDK-8299736). I've kept the related tests disabled for this platform and throw an exception instead. Note that the ABI doesn't precisely specify variable argument lists. Instead, it refers to `<stdarg.h>` (2.2.4 Variable Argument Lists).
>> 
>> Big Endian support is implemented to some extend, but not complete. E.g. structs with size not divisible by 8 are not passed correctly (see `useABIv2` in CallArranger.java). Big Endian is excluded by selecting `ARCH.equals("ppc64le")` (CABI.java) only.
>> 
>> There's another limitation: This PR only accepts structures with size divisible by 4. (An `IllegalArgumentException` gets thrown otherwise.) I think arbitrary sizes are not usable on other platforms, either, because `SharedUtils.primitiveCarrierForSize` only accepts powers of 2. Update: Resolved after merging of [JDK-8303017](https://bugs.openjdk.org/browse/JDK-8303017)
>> 
>> The ABI has some tricky corner cases related to HFA (Homogeneous Float Aggregate). The same argument may need to get passed in both, a FP reg and a GP reg or stack slot (see "no partial DW rule"). This cases are not covered by the existing tests.
>> 
>> I had to make changes to shared code and code for other platforms:
>> 1. Pass type information when creating `VMStorage` objects from `VMReg`. This is needed for the following reasons:
>> - PPC64 ABI requires integer types to get extended to 64 bit (also see CCallingConventionRequiresIntsAsLongs in existing hotspot code). We need to know the type or at least the bit width for that.
>> - Floating point load / store instructions need the correct width to select between the correct IEEE 754 formats. The register representation in single FP registers is always IEEE 754 double precision on PPC64.
>> - Big Endian also needs usage of the precise size. Storing 8 Bytes and loading 4 Bytes yields different values than on Little Endian!
>> 2. It happens that a `NativeMemorySegmentImpl` is used as a raw pointer (with byteSize() == 0) while running TestUpcallScope. Hence, existing size checks don't work (see MemorySegment.java). As a workaround, I'm just skipping the check in this particular case. Please check if this makes sense or if there's a better fix (possibly as separate RFE). Update: This issue is resolved by 2nd commit.
>
> Martin Doerr has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits:
> 
>  - Adaptation for JDK-8305668
>  - Merge remote-tracking branch 'origin' into PPC64_Panama
>  - Move ABIv2CallArranger out of linux subdirectory. ABIv1/2 does match the AIX/linux separation.
>  - Adaptation for JDK-8303022.
>  - Adaptation for JDK-8303684.
>  - Merge branch 'openjdk:master' into PPC64_Panama
>  - Merge branch 'master' into PPC64_Panama
>  - Fix Copyright format.
>  - Fix storing 32 bit integers into Java frames. Enable TestArrayStructs.
>  - Allow TestHFA to run on musl. Add Upcalls.
>  - ... and 14 more: https://git.openjdk.org/jdk/compare/3bba8995...725732a0

src/hotspot/cpu/ppc/frame_ppc.cpp line 219:

> 217:   UpcallStub* blob = _cb->as_upcall_stub();
> 218:   JavaFrameAnchor* jfa = blob->jfa_for_frame(*this);
> 219:   return jfa->last_Java_sp() == NULL;

Suggestion:

  return jfa->last_Java_sp() == nullptr;

I'd suggest to do the same for all occurrences in the patch.

src/hotspot/cpu/ppc/methodHandles_ppc.cpp line 316:

> 314:   // Load the invoker, as NEP -> .invoker
> 315:   __ verify_oop(nep_reg);
> 316:   __ ld(temp_target, jdk_internal_foreign_abi_NativeEntryPoint::downcall_stub_address_offset_in_bytes(), nep_reg);

Other platforms use `access_load_at`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12708#discussion_r1177973466
PR Review Comment: https://git.openjdk.org/jdk/pull/12708#discussion_r1177985899