RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v22]

Martin Doerr mdoerr at openjdk.org
Wed May 10 11:16:44 UTC 2023


On Wed, 26 Apr 2023 14:41:51 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Martin Doerr has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits:
>> 
>>  - Adaptation for JDK-8305668
>>  - Merge remote-tracking branch 'origin' into PPC64_Panama
>>  - Move ABIv2CallArranger out of linux subdirectory. ABIv1/2 does match the AIX/linux separation.
>>  - Adaptation for JDK-8303022.
>>  - Adaptation for JDK-8303684.
>>  - Merge branch 'openjdk:master' into PPC64_Panama
>>  - Merge branch 'master' into PPC64_Panama
>>  - Fix Copyright format.
>>  - Fix storing 32 bit integers into Java frames. Enable TestArrayStructs.
>>  - Allow TestHFA to run on musl. Add Upcalls.
>>  - ... and 14 more: https://git.openjdk.org/jdk/compare/3bba8995...725732a0
>
> src/hotspot/cpu/ppc/methodHandles_ppc.cpp line 316:
> 
>> 314:   // Load the invoker, as NEP -> .invoker
>> 315:   __ verify_oop(nep_reg);
>> 316:   __ ld(temp_target, jdk_internal_foreign_abi_NativeEntryPoint::downcall_stub_address_offset_in_bytes(), nep_reg);
> 
> Other platforms use `access_load_at`.

Interesting. I have no idea why. It does the same but with a more complicated API.
I just noticed that other platforms use `NONZERO`. I think I should at least add that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12708#discussion_r1189752212


More information about the hotspot-dev mailing list