RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v22]

[Martin Doerr]

On Wed, 26 Apr 2023 14:32:59 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Martin Doerr has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits:
>> 
>>  - Adaptation for JDK-8305668
>>  - Merge remote-tracking branch 'origin' into PPC64_Panama
>>  - Move ABIv2CallArranger out of linux subdirectory. ABIv1/2 does match the AIX/linux separation.
>>  - Adaptation for JDK-8303022.
>>  - Adaptation for JDK-8303684.
>>  - Merge branch 'openjdk:master' into PPC64_Panama
>>  - Merge branch 'master' into PPC64_Panama
>>  - Fix Copyright format.
>>  - Fix storing 32 bit integers into Java frames. Enable TestArrayStructs.
>>  - Allow TestHFA to run on musl. Add Upcalls.
>>  - ... and 14 more: https://git.openjdk.org/jdk/compare/3bba8995...725732a0
>
> src/hotspot/cpu/ppc/frame_ppc.cpp line 219:
> 
>> 217:   UpcallStub* blob = _cb->as_upcall_stub();
>> 218:   JavaFrameAnchor* jfa = blob->jfa_for_frame(*this);
>> 219:   return jfa->last_Java_sp() == NULL;
> 
> Suggestion:
> 
>   return jfa->last_Java_sp() == nullptr;
> 
> I'd suggest to do the same for all occurrences in the patch.

Good catch! I've replaced them.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12708#discussion_r1189742225