RFR: 8302670: use-after-free related to PhaseIterGVN interaction with Unique_Node_List and Node_Stack [v2]

[Emanuel Peter]

On Wed, 10 May 2023 10:52:01 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update copyright years
>
> src/hotspot/share/opto/compile.hpp line 426:
> 
>> 424: 
>> 425:   // Shared type array for GVN, IGVN and CCP. It maps node ID -> Type*.
>> 426:   Type_Array*           _type_array;
> 
> Should we call this `_types` (or `_node_type`) instead?

will change to `_types`

> src/hotspot/share/opto/compile.hpp line 429:
> 
>> 427: 
>> 428:   // Shared node hash table for GVN, IGVN and CCP.
>> 429:   NodeHash*             _node_hash_table;
> 
> Should we call this `_node_hash` instead?

will change to `_node_hash`

> src/hotspot/share/opto/compile.hpp line 957:
> 
>> 955:     return *_type_array;
>> 956:   }
>> 957:   NodeHash& node_hash_table() {
> 
> Can we just use a pointer return value for these?

Will move change from pointer to reference to be in Phase constructor

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13833#discussion_r1189794438
PR Review Comment: https://git.openjdk.org/jdk/pull/13833#discussion_r1189794881
PR Review Comment: https://git.openjdk.org/jdk/pull/13833#discussion_r1189797404