RFR: 8302670: use-after-free related to PhaseIterGVN interaction with Unique_Node_List and Node_Stack [v2]

[Emanuel Peter]

On Wed, 10 May 2023 11:04:59 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update copyright years
>
> src/hotspot/share/opto/lcm.cpp line 1272:
> 
>> 1270:     // Block at same level in dom-tree is not a successor.  It needs a
>> 1271:     // PhiNode, the PhiNode uses from the def and IT's uses need fixup.
>> 1272:     Node_Array inputs;
> 
> Urgh, looks like we had object slicing here before your changes.

Yup, there were a few nasty things happening 😅

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13833#discussion_r1189807443