RFR: JDK-8307810: Consistently use LockingMode instead of UseHeavyMonitors
Amit Kumar
amitkumar at openjdk.org
Wed May 10 12:52:21 UTC 2023
On Wed, 10 May 2023 11:21:05 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> [JDK-8291555](https://bugs.openjdk.org/browse/JDK-8291555) phased out UseHeavyMonitors in favor of LockingMode=0. We forgot to apply these changes to PPC and S390.
>>
>> Since UseHeavyMonitors implies LockingMode, but not vice versa, we now have a mismatch if JVM is started with LockingMode=0 but without UseHeavyMonitors. That leads to crashes.
>>
>> The patch fixes that, and in addition makes sure that if LockingMode=0 is set, we are setting UseHeavyMonitors too.
>
> @MBaesken @TheRealMDoerr could you test this please on your CI and check if this fixes ppcle and s390? Thanks!
Hi @tstuefe, Not sure how correct I am, but UseHeavyMonitors is not implemented for s390x, You may see an Issue open for this [here](https://bugs.openjdk.org/browse/JDK-8278411). So i guess if you set UseHeavyMonitors to true for s390x, then build will fail.
>Looks like the build fails now in arguments.cpp on a few platforms.
@MBaesken does that include s390x ?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13900#issuecomment-1542151094
More information about the hotspot-dev
mailing list