RFR: JDK-8307810: Consistently use LockingMode instead of UseHeavyMonitors

Amit Kumar amitkumar at openjdk.org
Thu May 11 02:52:44 UTC 2023


On Wed, 10 May 2023 12:47:44 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> @MBaesken @TheRealMDoerr could you test this please on your CI and check if this fixes ppcle and s390? Thanks!
>
> Hi @tstuefe, Not sure how correct I am, but UseHeavyMonitors is not implemented for s390x, You may see an Issue open for this [here](https://bugs.openjdk.org/browse/JDK-8278411). So i guess if you set UseHeavyMonitors to true for s390x, then build will fail.
> 
>>Looks like the build fails now in arguments.cpp on a few platforms.
> 
> @MBaesken does that include s390x ?

>@offamitkumar: I think s390 requires additional changes in MacroAssembler::compiler_fast_lock_object and MacroAssembler::compiler_fast_unlock_object, but that should probably better be done separately.

Sure Martin, I'll look into. 

Thank you.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13900#issuecomment-1543253766


More information about the hotspot-dev mailing list