RFR: 8307139: Fix signed integer overflow in compiler code, part 1 [v3]

Dean Long dlong at openjdk.org
Thu May 11 03:16:52 UTC 2023


> These changes attempt to fix signed overflow caught by running tier1 with -ftrapv.  I expect more changes will be needed.
> Most of the fixes are straight-forward and involve using unsigned or java_* functions that wrap.  However, I did try to improve the usefulness of _debug_idx because as it was the high digits of the value were monotonic but unpredictable.  Now the high digits use the compile_id, which seems like an improvement.

Dean Long has updated the pull request incrementally with three additional commits since the last revision:

 - Update src/hotspot/share/opto/intrinsicnode.cpp
   
   Co-authored-by: Roberto Castañeda Lozano <robcasloz at users.noreply.github.com>
 - Update src/hotspot/share/c1/c1_Canonicalizer.cpp
   
   Co-authored-by: Roberto Castañeda Lozano <robcasloz at users.noreply.github.com>
 - Update src/hotspot/share/c1/c1_Canonicalizer.cpp
   
   Co-authored-by: Roberto Castañeda Lozano <robcasloz at users.noreply.github.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13767/files
  - new: https://git.openjdk.org/jdk/pull/13767/files/41f141ed..36011424

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13767&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13767&range=01-02

  Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/13767.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13767/head:pull/13767

PR: https://git.openjdk.org/jdk/pull/13767


More information about the hotspot-dev mailing list