RFR: 8307139: Fix signed integer overflow in compiler code, part 1 [v3]
Vladimir Kozlov
kvn at openjdk.org
Thu May 11 16:25:54 UTC 2023
On Thu, 11 May 2023 03:16:52 GMT, Dean Long <dlong at openjdk.org> wrote:
>> These changes attempt to fix signed overflow caught by running tier1 with -ftrapv. I expect more changes will be needed.
>> Most of the fixes are straight-forward and involve using unsigned or java_* functions that wrap. However, I did try to improve the usefulness of _debug_idx because as it was the high digits of the value were monotonic but unpredictable. Now the high digits use the compile_id, which seems like an improvement.
>
> Dean Long has updated the pull request incrementally with three additional commits since the last revision:
>
> - Update src/hotspot/share/opto/intrinsicnode.cpp
>
> Co-authored-by: Roberto Castañeda Lozano <robcasloz at users.noreply.github.com>
> - Update src/hotspot/share/c1/c1_Canonicalizer.cpp
>
> Co-authored-by: Roberto Castañeda Lozano <robcasloz at users.noreply.github.com>
> - Update src/hotspot/share/c1/c1_Canonicalizer.cpp
>
> Co-authored-by: Roberto Castañeda Lozano <robcasloz at users.noreply.github.com>
Looks good.
-------------
Marked as reviewed by kvn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13767#pullrequestreview-1423001607
More information about the hotspot-dev
mailing list