RFR: 8307804: Reorganize ArrayJuggle test cases [v2]

Leo Korinth lkorinth at openjdk.org
Tue May 16 12:58:44 UTC 2023


On Mon, 15 May 2023 09:27:05 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

>> Move all ArrayJuggle test cases to the same directory: test/hotspot/jtreg/vmTestbase/gc/ArrayJuggle
>> 
>> Rename Juggle01 to Juggle3 (so it will not be confused with Juggle1)
>> 
>> Remove all directories and files used to launch the tests, instead use multiple  `@test id=xx` "annotations" in the four kept test files.
>> 
>> Create a new test file Juggle3Quick.java that will act as a quick group of tests. Unfortunately `#id` selectors can not be used in test groups so this is a workaround. See: https://bugs.openjdk.org/browse/CODETOOLS-7903467
>
> Leo Korinth has updated the pull request incrementally with one additional commit since the last revision:
> 
>   rerun tests

Regarding multi line format, I think there is a strong value of being able to "scan" line after line seeing what permutations are tested. I recently fixed [JDK-8306435](https://bugs.openjdk.org/browse/JDK-8306435) --- such bugs would be much harder to make if we can easily "scan" the permutations, and was one reason why I choose to reorganise the tests.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13929#issuecomment-1549608456


More information about the hotspot-dev mailing list