RFR: 8307804: Reorganize ArrayJuggle test cases [v2]

Leonid Mesnik lmesnik at openjdk.org
Tue May 16 21:27:45 UTC 2023


On Mon, 15 May 2023 09:27:05 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

>> Move all ArrayJuggle test cases to the same directory: test/hotspot/jtreg/vmTestbase/gc/ArrayJuggle
>> 
>> Rename Juggle01 to Juggle3 (so it will not be confused with Juggle1)
>> 
>> Remove all directories and files used to launch the tests, instead use multiple  `@test id=xx` "annotations" in the four kept test files.
>> 
>> Create a new test file Juggle3Quick.java that will act as a quick group of tests. Unfortunately `#id` selectors can not be used in test groups so this is a workaround. See: https://bugs.openjdk.org/browse/CODETOOLS-7903467
>
> Leo Korinth has updated the pull request incrementally with one additional commit since the last revision:
> 
>   rerun tests

Thanks for this clean up. There are few comments about names.

test/hotspot/jtreg/vmTestbase/gc/ArrayJuggle/Juggle3.java line 29:

> 27: 
> 28: // Run in Juggle3Quic.java @test id=1  @key stress randomness @library /vmTestbase /test/lib @run main/othervm -XX:+HeapDumpOnOutOfMemoryError -Xlog:gc=debug:gc.log gc.ArrayJuggle.Juggle3 -gp byteArr -ms low
> 29: /* @test id=2  @key stress randomness @library /vmTestbase /test/lib @run main/othervm -XX:+HeapDumpOnOutOfMemoryError -Xlog:gc=debug:gc.log gc.ArrayJuggle.Juggle3 -gp byteArr -ms medium */

It would be much better to have a meaningful id like 'gc_byteArr_ms_medium'. So we can easier identify failures and easily add/remove rearrange testcases.

-------------

PR Review: https://git.openjdk.org/jdk/pull/13929#pullrequestreview-1429455832
PR Review Comment: https://git.openjdk.org/jdk/pull/13929#discussion_r1195700322


More information about the hotspot-dev mailing list