RFR: 8307804: Reorganize ArrayJuggle test cases [v2]
Leo Korinth
lkorinth at openjdk.org
Fri May 19 08:41:51 UTC 2023
On Tue, 16 May 2023 21:21:58 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
>> Leo Korinth has updated the pull request incrementally with one additional commit since the last revision:
>>
>> rerun tests
>
> test/hotspot/jtreg/vmTestbase/gc/ArrayJuggle/Juggle3.java line 29:
>
>> 27:
>> 28: // Run in Juggle3Quic.java @test id=1 @key stress randomness @library /vmTestbase /test/lib @run main/othervm -XX:+HeapDumpOnOutOfMemoryError -Xlog:gc=debug:gc.log gc.ArrayJuggle.Juggle3 -gp byteArr -ms low
>> 29: /* @test id=2 @key stress randomness @library /vmTestbase /test/lib @run main/othervm -XX:+HeapDumpOnOutOfMemoryError -Xlog:gc=debug:gc.log gc.ArrayJuggle.Juggle3 -gp byteArr -ms medium */
>
> It would be much better to have a meaningful id like 'gc_byteArr_ms_medium'. So we can easier identify failures and easily add/remove rearrange testcases.
I added IDs with names although a bit shorter.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13929#discussion_r1198702689
More information about the hotspot-dev
mailing list