RFR: 8302351: "assert(!JavaThread::current()->is_interp_only_mode() || !nm->method()->is_continuation_enter_intrinsic() || ContinuationEntry::is_interpreted_call(return_pc)) failed: interp_only_mode but not in enterSpecial interpreted entry" in fixup_callers_callsite

[Andrew Haley]

On Wed, 24 May 2023 20:13:55 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> I considered that initially but I preferred the readability part given that we are not saving much. But I can do that if you think it's better that way.
>
> I'm not totally sold on the refactoring being a better idea. I would be okay if you
> decided not to do that. Let's see if any other reviewer has an opinion one way or
> the other.

I wonder if something like

`callee_method->from_compiled_entry(current->is_interp_only_mode())`

might be readable and well factored.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14108#discussion_r1207105687