RFR: 8302351: "assert(!JavaThread::current()->is_interp_only_mode() || !nm->method()->is_continuation_enter_intrinsic() || ContinuationEntry::is_interpreted_call(return_pc)) failed: interp_only_mode but not in enterSpecial interpreted entry" in fixup_callers_callsite

Patricio Chilano Mateo pchilanomate at openjdk.org
Fri May 26 18:42:02 UTC 2023


On Fri, 26 May 2023 17:19:59 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> I'm not totally sold on the refactoring being a better idea. I would be okay if you
>> decided not to do that. Let's see if any other reviewer has an opinion one way or
>> the other.
>
> I wonder if something like
> 
> `callee_method->from_compiled_entry(current->is_interp_only_mode())`
> 
> might be readable and well factored.

Yes, that works. I can do that but I'll wait since we might not go with this solution after all.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14108#discussion_r1207190541


More information about the hotspot-dev mailing list