RFR: 8308997: RISC-V: Sign extend when comparing 32-bit value with zero instead of testing the sign bit [v2]

Dingli Zhang dzhang at openjdk.org
Tue May 30 02:11:43 UTC 2023


On Tue, 30 May 2023 01:57:41 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix some comments
>
> src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp line 985:
> 
>> 983:       __ sign_extend(dest->as_register(), src->as_register(), 8); break;
>> 984:     case Bytecodes::_l2i:
>> 985:       _masm->block_comment("FIXME: This could be a no-op");
> 
> We should remove this block comment as it's not applicable for riscv here.

Thanks! Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14197#discussion_r1209639583


More information about the hotspot-dev mailing list