RFR: 8308252: Refactor line-by-line file reading code [v6]
Ioi Lam
iklam at openjdk.org
Tue May 30 03:10:13 UTC 2023
On Wed, 24 May 2023 23:41:22 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> I extracted the `get_line()` code from `CompileReplay` and put it in a utility class so that it can be used by `ClassListParser` as well. A few notable changes:
>>
>> - Simplified the API
>> - Changed the buffer size to a size_t
>> - Added size overflow and OOM checks
>> - Brought over the `fdopen` logic from `ClassListParser` for handling long path names on Windows. (I don't know how valid this is nowadays, but I don't want to drop it in a refactoring PR).
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>
> try to fix windows build
@rose00 has a alternative proposal for rewriting the buffed file reading code to support a more capable API. I will withdraw this PR for now.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14025#issuecomment-1567699740
More information about the hotspot-dev
mailing list