Withdrawn: 8308252: Refactor line-by-line file reading code

Ioi Lam iklam at openjdk.org
Tue May 30 03:10:15 UTC 2023


On Wed, 17 May 2023 03:46:12 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> I extracted the `get_line()` code from `CompileReplay` and put it in a utility class so that it can be used by `ClassListParser` as well. A few notable changes:
> 
> - Simplified the API
> - Changed the buffer size to a size_t
> - Added size overflow and OOM checks
> - Brought over the `fdopen` logic from `ClassListParser` for handling long path names on Windows. (I don't know how valid this is nowadays, but I don't want to drop it in a refactoring PR).

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk/pull/14025


More information about the hotspot-dev mailing list