RFR: 8309171: Test vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/TestDescription.java fails after JDK-8308341

[Daniel D. Daugherty]

On Wed, 31 May 2023 06:41:26 GMT, David Holmes <dholmes at openjdk.org> wrote:

> The fix for [JDK-8308341](https://bugs.openjdk.org/browse/JDK-8308341) overlooked the fact that during VM initialization agents can run and create native threads that will attach to (and potentially detach from) the VM. The check that VM init was complete before allowing those operations was too strong and has to be reverted. All the guards, except for that of GetCreatedJavaVMs itself, is reverted to the way it was before JDK-8308341.
> 
> Testing: tiers 1-4 (in progress)
> 
> Thanks.

Thumbs up. The fix appears to do exactly what you described in the bug report.
Hopefully your in process testing goes well.

src/hotspot/share/prims/jni.cpp line 3994:

> 3992:   if (vm_created == NOT_CREATED) {
> 3993:     // Not sure how we could possibly get here.
> 3994:   HOTSPOT_JNI_ATTACHCURRENTTHREADASDAEMON_RETURN((uint32_t) JNI_ERR);

Indent is wrong. It's not caused by your changes, but could you fix it?

-------------

Marked as reviewed by dcubed (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14239#pullrequestreview-1453269041
PR Review Comment: https://git.openjdk.org/jdk/pull/14239#discussion_r1211748838