RFR: 8309171: Test vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/TestDescription.java fails after JDK-8308341 [v2]
David Holmes
dholmes at openjdk.org
Wed May 31 21:13:48 UTC 2023
On Wed, 31 May 2023 13:47:34 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:
>> David Holmes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>>
>> - Undo ProblemList.txt update
>> - Fixed indent
>> - Merge branch 'master' into 8309171-attach-failure
>> - 8309171: Test vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/TestDescription.java fails after JDK-8308341
>
> src/hotspot/share/prims/jni.cpp line 3994:
>
>> 3992: if (vm_created == NOT_CREATED) {
>> 3993: // Not sure how we could possibly get here.
>> 3994: HOTSPOT_JNI_ATTACHCURRENTTHREADASDAEMON_RETURN((uint32_t) JNI_ERR);
>
> Indent is wrong. It's not caused by your changes, but could you fix it?
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14239#discussion_r1212313462
More information about the hotspot-dev
mailing list