RFR: 8319781: RISC-V: Refactor UseRVV related checks

Hamlin Li mli at openjdk.org
Mon Nov 13 12:09:59 UTC 2023


On Mon, 13 Nov 2023 10:31:39 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:

>> Hi,
>> Can you review the patch to refactor the code related UseRVV checks?
>> Thanks!
>> 
>> There are some code (flag setting/checking) depending on UseRVV's value, these code should be refactored, especially after the change of https://bugs.openjdk.org/browse/JDK-8319408:
>> 1. some code needs to get the final UseRVV's value rather than the initial value, e.g. ChaCha20 intrinsic.
>> 2. refactored to be more readable.
>> 3. also add note to make sure the future code get the final UseRVV value instead of inital value.
>
> src/hotspot/cpu/riscv/vm_version_riscv.cpp line 269:
> 
>> 267: #endif // COMPILER2
>> 268: 
>> 269:   // NOTE: Make sure codes dependent on UseRVV are put at the behind of c2_initialize(),
> 
> Suggestion:
> 
>   // NOTE: Make sure codes dependent on UseRVV are put after c2_initialize(),

Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16580#discussion_r1391028995


More information about the hotspot-dev mailing list