RFR: 8318218: RISC-V: C2 CompressBits [v7]

Fei Yang fyang at openjdk.org
Mon Nov 13 14:47:01 UTC 2023


On Mon, 13 Nov 2023 12:15:29 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you review the change to add intrinsic for CompressBits for Long & Integer?
>> Thanks!
>> 
>> ## Test
>> pass jtreg test:
>> test/jdk/java/lang/CompressExpand*.java
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   refine code

src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 1702:

> 1700:   vmv_v_i(v8, 0);
> 1701:   // load the mask data(in bits).
> 1702:   vsetivli(x0, 1, sew, lmul);

Please also change line into "vsetivli(x0, 1, sew, Assembler::m1)" for consistency. Otherwise LGTM.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16481#discussion_r1391210994


More information about the hotspot-dev mailing list