RFR: 8314220: Configurable InlineCacheBuffer size [v2]

Dean Long dlong at openjdk.org
Tue Nov 14 03:24:27 UTC 2023


On Mon, 13 Nov 2023 14:40:23 GMT, Ekaterina Vergizova <evergizova at openjdk.org> wrote:

>> src/hotspot/share/runtime/flags/jvmFlagConstraintsCompiler.cpp line 459:
>> 
>>> 457:   }
>>> 458: 
>>> 459:   if ((value % CodeEntryAlignment) != 0) {
>> 
>> I don't understand why this is necessary.
>
> It is needed to avoid 'failed: _buffer_size  not aligned' crashes on debug builds: 
> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/code/stubs.cpp#L221

That sounds like a bug.  We already align the code_begin().  I see no reason to align code_end() as well.  It just wastes space.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15271#discussion_r1391940158


More information about the hotspot-dev mailing list