RFR: 8314220: Configurable InlineCacheBuffer size [v3]
Ekaterina Vergizova
evergizova at openjdk.org
Mon Nov 20 23:22:06 UTC 2023
On Tue, 14 Nov 2023 03:26:44 GMT, Dean Long <dlong at openjdk.org> wrote:
>> Thanks @dean-long.
>> I would like to keep this enhancement simple and minimal so that it can be backported to 17 and 11.
>> So I'd like to avoid changes to StubQueue. I can change the type of InlineCacheBufferSize to size_t and add checked_cast to StubQueue constructor in InlineCacheBuffer::initialize():
>> _buffer = new StubQueue(new ICStubInterface, checked_cast<int>(InlineCacheBufferSize), InlineCacheBuffer_lock, "InlineCacheBuffer");
>>
>> Because in any case InlineCacheBufferSize can't be greater than INT_MAX:
>> `InlineCacheBufferSize < NonNMethodCodeHeapSize < ReservedCodeCacheSize < CODE_CACHE_DEFAULT_LIMIT = 2G`:
>> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/code/codeCache.cpp#L191
>> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/compiler/compilerDefinitions.cpp#L492
>> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/utilities/globalDefinitions.hpp#L589
>>
>> Will that be OK?
>
> OK.
done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15271#discussion_r1399858296
More information about the hotspot-dev
mailing list