RFR: 8319999: Refactor MetaspaceShared::use_full_module_graph() [v2]

[Ioi Lam]

On Tue, 14 Nov 2023 04:29:06 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   rename FileMapHeader::_use_full_module_graph -> _has_full_module_graph
>
> src/hotspot/share/cds/cdsConfig.cpp line 34:
> 
>> 32: bool CDSConfig::_is_dumping_dynamic_archive = false;
>> 33: bool CDSConfig::_enable_dumping_full_module_graph = true;
>> 34: bool CDSConfig::_enable_loading_full_module_graph = true;
> 
> The "enable" naming isn't quite right - these fields hold the enabled state e.g. `_dumping_full_module_graph_enabled`.

I like the variable name to be the same as the function name, so it's easier to search. We also have `bool _enable_preview;` in arguments.hpp

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16646#discussion_r1391992956