RFR: 8319999: Refactor MetaspaceShared::use_full_module_graph() [v2]

[David Holmes]

On Tue, 14 Nov 2023 04:54:24 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> src/hotspot/share/cds/filemap.cpp line 216:
>> 
>>> 214:   _max_heap_size = MaxHeapSize;
>>> 215:   _use_optimized_module_handling = MetaspaceShared::use_optimized_module_handling();
>>> 216:   _has_full_module_graph = CDSConfig::is_dumping_full_module_graph();
>> 
>> `_uses_full_module_graph` would seem more appropriate than `use` or `has`
>
> The name is consistent with other fields in filemap.hpp:
> 
> 
>   bool _has_non_jar_in_classpath;     // non-jar file entry exists in classpath
>   bool _has_platform_or_app_classes;  // Archive contains app classes
>   bool _has_full_module_graph;        // Does this CDS archive contain the full archived module graph?

Okay makes more sense when expressed like that - but it is not obvious that the MetaspaceShared API should be read as applying "to this CDS archive".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16646#discussion_r1391996994