RFR: 8319999: Refactor MetaspaceShared::use_full_module_graph() [v2]

Ioi Lam iklam at openjdk.org
Tue Nov 14 05:36:26 UTC 2023


On Tue, 14 Nov 2023 05:20:15 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> The alignment is the same as the is_dumping_xxx()/enable_dumping_xxx() functions below, so it's easier to read the "dumping" and "loading" part of the names.
>
> Sorry that is not a valid reason IMO. It's bad enough when people want the start of names to line up, never-mind the middle of them!

That's my personal preference. Many people align the code differently. Are there any rules in the code guide about code alignments?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16646#discussion_r1392002360


More information about the hotspot-dev mailing list