RFR: 8318986: Improve GenericWaitBarrier performance [v6]

[Ivan Walulya]

On Tue, 14 Nov 2023 14:37:58 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> See the symptoms, reproducer and analysis in the bug.
>> 
>> Current code waits on `disarm()`, which effectively stalls leaving the safepoint if some threads lag behind. Having more runnable threads than CPUs nearly guarantees that we would wait for quite some time, but it also reproduces well if you have enough threads near the CPU count. Just waiting at `arm()` is insufficient, but we can have several `Semaphores` to do what we want. 
>> 
>> This PR implements a more efficient `GenericWaitBarrier` to recover the performance. Most of the implementation discussion is in the code comments. The key observation that drives this work is that we want to reuse `Semaphore` and related counters without being stuck waiting for threads to leave.
>> 
>> (AFAICS, futex-based `LinuxWaitBarrier` does roughly the same, but handles this reuse on futex side, by assigning the "address" per futex.)
>> 
>> This issue affects everything except Linux. I initially found this on my M1 Mac, but pretty sure it is easy to reproduce on Windows as well. The safepoints from the reproducer in the bug improved dramatically on a Mac. Note not only the orders of magnitude better safepoint times, but also the several times more GC safepoints in the time-bound allocation test, which means the attainable GC throughput is similarly better, since we don't waste time at this wait barrier.
>> 
>> ![plot-generic-wait-barrier-macos](https://github.com/openjdk/jdk/assets/1858943/3440f200-2360-482a-b8b2-71385cca35b7)
>> 
>> Additional testing:
>>   - [x] MacOS AArch64 server fastdebug, `tier1`
>>   - [x] Linux x86_64 server fastdebug, `tier1 tier2 tier3` (generic wait barrier enabled explicitly)
>>   - [x] Linux AArch64 server fastdebug, `tier1 tier2 tier3` (generic wait barrier enabled explicitly)
>>   - [x] MacOS AArch64 server fastdebug, `tier2 tier3`
>>   - [x] Linux x86_64 server fastdebug, `tier4` (generic wait barrier enabled explicitly)
>>   - [x] Linux AArch64 server fastdebug, `tier4` (generic wait barrier enabled explicitly)
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision:
> 
>  - Drop the Linux check in preparation for integration
>  - Merge branch 'master' into JDK-8318986-generic-wait-barrier
>  - Merge branch 'master' into JDK-8318986-generic-wait-barrier
>  - Rework paddings
>  - Encode barrier tag into state, resolving another race condition
>  - Simple review feedback fixes: tracking wakeup numbers, reflowing some methods
>  - Merge branch 'master' into JDK-8318986-generic-wait-barrier
>  - Touchups
>  - More comments work
>  - Tight up the comments
>  - ... and 3 more: https://git.openjdk.org/jdk/compare/2277bc30...191c0dbb

LGTM!

src/hotspot/share/utilities/waitBarrier_generic.cpp line 119:

> 117: void GenericWaitBarrier::Cell::arm(int32_t requested_tag) {
> 118:   // Before we continue to arm, we need to make sure that all threads
> 119:   // have left the previous cell.

// have left after the previous usage of the cell.

-------------

Marked as reviewed by iwalulya (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16404#pullrequestreview-1738568875
PR Review Comment: https://git.openjdk.org/jdk/pull/16404#discussion_r1398349635