RFR: 8318986: Improve GenericWaitBarrier performance [v6]

Aleksey Shipilev shade at openjdk.org
Mon Nov 20 09:47:40 UTC 2023


On Sun, 19 Nov 2023 08:09:39 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision:
>> 
>>  - Drop the Linux check in preparation for integration
>>  - Merge branch 'master' into JDK-8318986-generic-wait-barrier
>>  - Merge branch 'master' into JDK-8318986-generic-wait-barrier
>>  - Rework paddings
>>  - Encode barrier tag into state, resolving another race condition
>>  - Simple review feedback fixes: tracking wakeup numbers, reflowing some methods
>>  - Merge branch 'master' into JDK-8318986-generic-wait-barrier
>>  - Touchups
>>  - More comments work
>>  - Tight up the comments
>>  - ... and 3 more: https://git.openjdk.org/jdk/compare/de6f765d...191c0dbb
>
> src/hotspot/share/utilities/waitBarrier_generic.cpp line 119:
> 
>> 117: void GenericWaitBarrier::Cell::arm(int32_t requested_tag) {
>> 118:   // Before we continue to arm, we need to make sure that all threads
>> 119:   // have left the previous cell.
> 
> // have left after the previous usage of the cell.

Thanks, but I think current wording is better.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16404#discussion_r1398915987


More information about the hotspot-dev mailing list