RFR: 8320418: PPC64: invokevfinal_helper duplicates code to handle ResolvedMethodEntry

Martin Doerr mdoerr at openjdk.org
Wed Nov 22 13:22:14 UTC 2023


On Tue, 21 Nov 2023 11:45:10 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> It is out of this scope. And it is a misnomer that will confuse people.
>
> Agreed. Thanks for the review!

@matias9927: `ResolvedMethodEntry::_number_of_parameters` is a misleading name. It's not the number of parameters, it's the number of parameter stack slots. Not every parameter uses only one slot. You may want to improve this in the future.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16741#discussion_r1402034991


More information about the hotspot-dev mailing list