RFR: 8315559: Delay TempSymbol cleanup to avoid symbol table churn [v10]

[Coleen Phillimore]

On Mon, 13 Nov 2023 01:20:19 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Oli Gillespie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix indentation, rename test helper
>
> src/hotspot/share/oops/symbolHandle.hpp line 59:
> 
>> 57:   // Conversion from a Symbol* to a SymbolHandleBase.
>> 58:   // Does not increment the current reference count if temporary.
>> 59:   SymbolHandleBase(Symbol *s) : _temp(s) {
> 
> Is this really called with nullptr sometimes?  It would be better if that was disallowed.  But that's probably
> outside the scope of this PR.

Yes SymbolHandle can be null.  There's a SymbolHandle field in the PlaceholderEntry called supername which is set to nullptr.  At least this is one instance where SymbolHandle can be null.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16398#discussion_r1406907726