RFR: 8315559: Delay TempSymbol cleanup to avoid symbol table churn [v10]

Oli Gillespie ogillespie at openjdk.org
Tue Nov 28 14:27:49 UTC 2023


On Mon, 27 Nov 2023 18:04:17 GMT, Oli Gillespie <ogillespie at openjdk.org> wrote:

>> test/hotspot/gtest/classfile/test_placeholders.cpp line 45:
>> 
>>> 43:   Symbol* D = SymbolTable::new_symbol("def2_8_2023_class");
>>> 44:   Symbol* super = SymbolTable::new_symbol("super2_8_2023_supername");
>>> 45:   Symbol* interf = SymbolTable::new_symbol("interface2_8_2023_supername");
>> 
>> This doesn't seem like the right way to update this test.  Doesn't this leave the symbols dangling?
>> And in the face of potential queue draining, it seems to me this could lead the test to intermittent failures.
>
> Updated to use the same 'create then drain' approach as the other test.

Now just manually cleaning up as suggested by Coleen

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16398#discussion_r1407845585


More information about the hotspot-dev mailing list