RFR: 8320530: has_resolved_ref_index flag not restored after resetting entry [v2]

[Coleen Phillimore]

On Wed, 29 Nov 2023 06:30:44 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Added asserts to ensure correctness
>>  - Merge branch 'master' into resolved_ref_flag
>>  - Merge branch 'master' of https://github.com/openjdk/jdk into resolved_ref_flag
>>  - 8320530: has_resolved_ref_index flag not restored after resetting entry
>
> src/hotspot/share/oops/resolvedMethodEntry.hpp line 80:
> 
>> 78:   u1 _flags;                         // Flags: [00|has_resolved_ref_index|has_local_signature|has_appendix|forced_virtual|final|virtual_final]
>> 79:   u1 _bytecode1, _bytecode2;         // Resolved invoke codes
>> 80:   DEBUG_ONLY(
> 
> Nit: it is better to use `#ifdef ASSERT` than a multi-line `DEBUG_ONLY()` - and that will also allow the correct indentation for the new variables.

I see, I said the opposite.  I don't like the #ifdef ASSERT blocks.  3 lines vs 1.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16769#discussion_r1410686620