RFR: 8320530: has_resolved_ref_index flag not restored after resetting entry [v2]

[Coleen Phillimore]

On Thu, 30 Nov 2023 13:37:57 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/oops/resolvedMethodEntry.hpp line 80:
>> 
>>> 78:   u1 _flags;                         // Flags: [00|has_resolved_ref_index|has_local_signature|has_appendix|forced_virtual|final|virtual_final]
>>> 79:   u1 _bytecode1, _bytecode2;         // Resolved invoke codes
>>> 80:   DEBUG_ONLY(
>> 
>> Nit: it is better to use `#ifdef ASSERT` than a multi-line `DEBUG_ONLY()` - and that will also allow the correct indentation for the new variables.
>
> I see, I said the opposite.  I don't like the #ifdef ASSERT blocks.  3 lines vs 1.

I think each variable should have DEBUG_ONLY() around it, not grouped though.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16769#discussion_r1410688666