RFR: 8316309: AArch64: VMError::print_native_stack() crashes on Java native method frame [v2]

[David Holmes]

On Fri, 29 Sep 2023 15:19:03 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> src/hotspot/share/utilities/vmError.cpp line 434:
>> 
>>> 432:       return invalid;
>>> 433:     }
>>> 434:     if (fr.is_interpreted_frame() || (fr.cb() != nullptr && fr.cb()->frame_size() > 0)) {
>> 
>> This part of the fix is unclear to me. How do the old conditions relate to the new ones?
>
> The second part of the condition includes the previous checks for is_compiled_frame(), is_native_frame(), is_runtime_frame() plus any other frame that would use sender_for_compiled_frame() when calling frame::sender(), like the safepoint stub.

So what is left that is not covered by that condition? Just wondering if there is a simpler form that makes it somewhat clearer what this actually tests for as the old condition was easily understandable and the new one is obscure.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15972#discussion_r1343635939