RFR: 8316309: AArch64: VMError::print_native_stack() crashes on Java native method frame [v2]

[Andrew Haley]

On Tue, 3 Oct 2023 19:24:06 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

> Yes, it's also the same code we have in frame::sender_raw(). I'm not sure how we can get to that native frame case when we use frame::sender() though. So if we start from the last Java frame we shouldn't find a native frame in the chain. And when we start from os::current_frame() we use VMError::print_native_stack() which uses os::get_sender_for_C_frame() for native frames. The only case I see is the debug utility ps(), which in case there is no last Java frame, creates a frame with os::current_frame() and then uses frame::sender(). So seems either we should change that last line in sender_raw() to be os::get_sender_for_C_frame() or replace it with an assert(false, "") and fix ps().

Yes, I see. OK for now, thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15972#discussion_r1345433837