RFR: 8301997: Move method resolution information out of the cpCache [v2]

[Andrew Dinn]

On Tue, 17 Oct 2023 16:50:11 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/templateTable_aarch64.cpp line 2369:
>> 
>>> 2367: }
>>> 2368: 
>>> 2369: void TemplateTable::load_resolved_method_entry_common(Register cache,
>> 
>> When I saw the `common` suffix I thought at first that this might be used in addition to the variants with the other suffixes rather than as an alternative. Since this is 'common' to only to 2 out of the 5 different cases perhaps it could be named `load_resolved_method_entry_special_or_static`. That would make it clear that each invoke type has a corresponding `load_resolved_method_entry_<invoketype>` variant.
>
> I struggled with naming this method which is why I settled on `common` but you are correct that it gives the wrong impression. However, I think `load_resolved_method_entry_special_or_static` is too verbose (44 characters!). Do you think there is a better name or is our best option to use this longer one?

Yes, it's a long name but it clarifies the intended purpose consistently with the names for the other cases. I think it is best to stick with it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15455#discussion_r1363807321