RFR: 8301997: Move method resolution information out of the cpCache [v2]

[Matias Saavedra Silva]

On Wed, 18 Oct 2023 07:56:12 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed some comments and relocated code
>
> src/hotspot/share/interpreter/rewriter.cpp line 244:
> 
>> 242:     if ((*opc) == (u1)Bytecodes::_invokevirtual ||
>> 243:         // allow invokespecial as an alias, although it would be very odd:
>> 244:         ((*opc) == (u1)Bytecodes::_invokespecial && _pool->tag_at(cp_index).is_method())) {
> 
> I'm not clear why the assert for both cases has now been folded into an additional logic check for only one case. You don't seem to have added an else clause to handle the case where the opcode is `_invokespecial` and the pool tag is not a method. Can you explain this change?

This looks like a leftover of an earlier attempt to resolve the issue with invokespecial. I believe this can be reverted

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15455#discussion_r1364479834